Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Wno-deprecated-declarations for Linux/Mac build. #761

Closed
wants to merge 1 commit into from
Closed

Add -Wno-deprecated-declarations for Linux/Mac build. #761

wants to merge 1 commit into from
+2 −0

Conversation

James-ZHANG
Copy link
Contributor

We witnessed the following compile errors when building libfido2 on our MacOS build environment (Ventura with Xcode 14.3.1):

<our custom path>/libfido2/src/cbor.c:759:13: error: 'HMAC_CTX_new' is deprecated [-Werror,-Wdeprecated-declarations]
        if ((ctx = HMAC_CTX_new()) == NULL ||
                   ^
/usr/local/include/openssl/hmac.h:33:1: note: 'HMAC_CTX_new' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 HMAC_CTX *HMAC_CTX_new(void);
^
/usr/local/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/local/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))

IIUC this is because either -Wall or -Wextra includes -Wdeprecated-declarations and -Werror turns that into an error.

I'm not sure why the upstream did not have this error: maybe it's a specific issue for XCode 14.3.1 only?

Since we are still supporting OpenSSL 1.1, I think it makes sense to add -Wno-deprecated-declarations explicitly until we bump OpenSSL version to 3.0 (from the NEWS file Yubico is going to do so in 1.16?).

@LDVG
Copy link
Contributor

LDVG commented Dec 21, 2023

Hi,

This should already have been handled by us setting OPENSSL_API_COMPAT:

libfido2/CMakeLists.txt

Line 328 in de45438

add_definitions(-DOPENSSL_API_COMPAT=0x10100000L)

Is it possible your (custom?) build is missing this define?

@James-ZHANG
Copy link
Contributor Author

Is it possible your (custom?) build is missing this define?

Yes, exactly :). I knew OpenSSL has a way to avoid the deprecation warning and you reminded me.

My problem is that our build mistakenly includes the system-default OpenSSL@3 headers under /usr/local/, instead of an [email protected] one we build from source and install at a custom location. Our intent is to use the self-built [email protected] as dependency, thus when cmake resolves the libcrypto location, it finds our custom built one, sees it's [email protected], and therefore does not set the OPENSSL_API_COMPAT flag.

@James-ZHANG James-ZHANG deleted the fix-deprecated-declarations-warning branch December 22, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@James-ZHANG @LDVG