Add -Wno-deprecated-declarations for Linux/Mac build. #761
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We witnessed the following compile errors when building libfido2 on our MacOS build environment (Ventura with Xcode 14.3.1):
IIUC this is because either
-Wall
or-Wextra
includes-Wdeprecated-declarations
and-Werror
turns that into an error.I'm not sure why the upstream did not have this error: maybe it's a specific issue for XCode 14.3.1 only?
Since we are still supporting OpenSSL 1.1, I think it makes sense to add
-Wno-deprecated-declarations
explicitly until we bump OpenSSL version to 3.0 (from the NEWS file Yubico is going to do so in 1.16?).